From: R. Steve McKown Date: Fri, 3 Sep 2010 21:43:21 +0000 (-0600) Subject: GCC 4.4.3 seems to have proper bitfield support. X-Git-Tag: patchset/2.1.1-4.4~25 X-Git-Url: https://oss.titaniummirror.com/gitweb/?p=tinyos-2.x.git;a=commitdiff_plain;h=87eba3b4a58cfd7ce142d0ae3868923e7befc860 GCC 4.4.3 seems to have proper bitfield support. --- diff --git a/tos/chips/msp430/adc12/Msp430Adc12.h b/tos/chips/msp430/adc12/Msp430Adc12.h index 6e6854e8..6cbce017 100644 --- a/tos/chips/msp430/adc12/Msp430Adc12.h +++ b/tos/chips/msp430/adc12/Msp430Adc12.h @@ -164,15 +164,19 @@ enum sampcon_id_enum // The unique string for accessing HAL2 via ReadStream #define ADCC_READ_STREAM_SERVICE "AdcC.ReadStream.Client" -/* Test for GCC bug (bitfield access) - only version 3.2.3 is known to be stable */ +/* Test for GCC bug (bitfield access) - versions 3.2.3 and 4.4.3 are known to + * be stable + */ // TODO: check whether this is still relevant... #define GCC_VERSION (__GNUC__ * 100 + __GNUC_MINOR__ * 10 + __GNUC_PATCHLEVEL__) #if GCC_VERSION == 332 #error "The msp430-gcc version (3.3.2) contains a bug which results in false accessing \ of bitfields in structs and makes MSP430ADC12M.nc fail ! Use version 3.2.3 instead." #elif GCC_VERSION != 323 +#if GCC_VERSION < 443 #warning "This version of msp430-gcc might contain a bug which results in false accessing \ of bitfields in structs (MSP430ADC12M.nc would fail). Use version 3.2.3 instead." +#endif #endif #ifndef __msp430_have_adc12