X-Git-Url: https://oss.titaniummirror.com/gitweb?a=blobdiff_plain;f=src%2Fcp210x.c;h=8c39dd1225623baa0681c409c0a7f89e0cbf8514;hb=071e179a4dabb59c72590fee3ea53ccbe7a69e72;hp=af0302c1ba61613fd0563427ce4f47c1e659b70f;hpb=a50a97ae61aefa7a7795e46c71c1eee09ac951b6;p=cp210x.git

diff --git a/src/cp210x.c b/src/cp210x.c
index af0302c..8c39dd1 100644
--- a/src/cp210x.c
+++ b/src/cp210x.c
@@ -147,10 +147,6 @@ static struct usb_serial_driver cp210x_device = {
 	.shutdown		= cp210x_shutdown,
 };
 
-/* Config request types */
-#define REQTYPE_HOST_TO_DEVICE	0x41
-#define REQTYPE_DEVICE_TO_HOST	0xc1
-
 /* Config SET requests. To GET, add 1 to the request number */
 #define CP2101_UART 		0x00	/* Enable / Disable */
 #define CP2101_BAUDRATE		0x01	/* (BAUD_RATE_GEN_FREQ / baudrate) */
@@ -207,36 +203,67 @@ static struct usb_serial_driver cp210x_device = {
 #define CP210x_PART_CP2102	0x02
 #define CP210x_PART_CP2103	0x03
 
-/*
- * cp210x_buf_from_user
- * Copy a buffer from user space, returning the number of bytes copied
- * from ubuf.buf into kbuf.  klen is the size of the buffer at kbuf.
+/* Return the size of the buffer needed to hold a string of len x formatted
+ * for send to CP210X, and its reverse.
+ */
+#define USBSTRLEN(strlen)	(strlen * 2 + 2)
+
+/* Populates usbstr with: (len) + (0x03) + unicode(str).  Each char in str
+ * takes two bytes in unicode format.
+ * Returns the resulting length of the string in usbstr.
+ * This function can accept overlapping usbstr and str as long as the overlap
+ * does not cause data written to usbstr to overwrite data not yet read from
+ * str.
  */
-static size_t cp210x_buf_from_user(char *kbuf, unsigned long ubuf, size_t klen)
+static int make_usb_string(char *usbstr, size_t usblen, char *src,
+		size_t srclen)
 {
-	struct cp210x_buffer t;
+	int len = 0;
 
-	if (!kbuf || !ubuf || !klen ||
-			copy_from_user(&t, (struct cp210x_buffer __user *)ubuf,
-			sizeof(t)))
-		return 0;
-	if (t.len < klen)
-		klen = t.len;
-	if (!t.buf || !t.len ||
-			copy_from_user(kbuf, (u8 __user *)t.buf, klen))
-		return 0;
-	return klen;
+	if (usbstr && usblen >= 2 && src && *src && srclen) {
+		char *p;
+
+		if (usblen > 255)
+			usblen = 255;
+
+		p = usbstr + 1;
+		*p++ = 0x03;
+		len = 2;
+		while (srclen && len < usblen) {
+			*p++ = *src++;
+			*p++ = 0;
+			len += 2;
+			srclen--;
+		}
+		*usbstr = (char)len;
+	}
+	return len;
 }
 
-/* cp210x_has_setmfg
- * Returns 1 if the CP210X part includes firmware that allows setting the
- * USB MFG descriptor, else 0.  As of this writing, no CP210X firmware allows
- * this.  SiLabs has suggested this may change in future firmware versions or
- * parts.
+/*
+ * cp210x_usbstr_from_user
+ * Populate kbuf with a usb string derived from a user space variable.  klen
+ * is the size of the buffer at kbuf.
+ * Returns the number of bytes used in kbuf.
  */
-static inline int cp210x_has_setmfg(void)
+static size_t cp210x_usbstr_from_user(char *kbuf,
+		struct cp210x_buffer __user *ubuf, size_t klen)
 {
-	return 0;
+	struct cp210x_buffer t;
+	char *str;
+	size_t slen;
+
+	if (copy_from_user(&t, ubuf, sizeof(t)))
+		return 0;
+	slen = (klen - 2) / 2;
+	if (!t.buf || !t.len || t.len > slen)
+		return 0;
+	if (t.len < slen)
+		slen = t.len;
+	str = kbuf + klen - slen;
+	if (copy_from_user(str, (__u8 __user *)t.buf, slen))
+		return 0;
+	return make_usb_string(kbuf, klen, str, slen);
 }
 
 /*
@@ -252,9 +279,10 @@ static int cp210x_ctlmsg(struct usb_serial_port *port, u8 request,
 	u8 *tbuf;
 	int ret;
 
-	if (!(tbuf = kmalloc(size, GFP_KERNEL)))
+	tbuf = kmalloc(size, GFP_KERNEL);
+	if (!tbuf)
 		return -ENOMEM;
-	if (requestype & 0x80) {
+	if (requestype & USB_DIR_IN) {
 		ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), request,
 				requestype, value, index, tbuf, size, 300);
 		if (ret > 0 && size)
@@ -267,8 +295,9 @@ static int cp210x_ctlmsg(struct usb_serial_port *port, u8 request,
 	}
 	kfree(tbuf);
 	if (ret < 0 && ret != -EPIPE) {
-		dev_printk(KERN_DEBUG, &dev->dev, "cp210x: control failed cmd rqt %u "
-				"rq %u len %u ret %d\n", requestype, request, size, ret);
+		dev_printk(KERN_DEBUG, &dev->dev,
+			"cp210x: ctl failed cmd rqt %u rq %u len %u ret %d\n",
+			requestype, request, size, ret);
 	}
 	return ret;
 }
@@ -277,16 +306,11 @@ static int cp210x_reset(struct usb_serial_port *port)
 {
 	dbg("%s", __FUNCTION__);
 
-#if 1
-	/* Is this better than usb_device_reset?  It may be.  Once a client issues
-	 * the reset ioctl, it must disconnect and reconnect, since the USB
-	 * connections are torn down.  We also ignore the error return, since
-	 * the part resets and doesn't send one...
+	/* Instructing the CP210X to reset seems to work more reliably than
+	 * calling usb_reset_device().
 	 */
-	cp210x_ctlmsg(port, 0xff, 0x40, 0x0008, 0x00, NULL, 0);
-#else
-	usb_reset_device(port->serial->dev);
-#endif
+	cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR,
+			0x0008, 0x00, NULL, 0);
 	return 0;
 }
 
@@ -303,8 +327,9 @@ static int cp210x_get_partnum(struct usb_serial_port *port)
 			_partnum = CP210x_PART_CP2101;
 		else if (addr == 0x01) {
 			/* Must query part to determine part number */
-			if (cp210x_ctlmsg(port, 0xff, 0xc0, 0x370b, 0x00,
-					&_partnum, 1) != 1)
+			if (cp210x_ctlmsg(port, 0xff,
+					USB_DIR_IN|USB_TYPE_VENDOR,
+					0x370b, 0x00, &_partnum, 1) != 1)
 				_partnum = CP210x_PART_UNKNOWN;
 		}
 	}
@@ -315,41 +340,8 @@ static int cp210x_get_partnum(struct usb_serial_port *port)
 static inline int cp210x_setu16(struct usb_serial_port *port, int cmd,
 		unsigned int value)
 {
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x3700 | (cmd & 0xff),
-			value, NULL, 0);
-}
-
-/* Populates usbstr with: (len) + (0x03) + unicode(str).  Each char in str
- * takes up two bytes in unicode format, so the resulting len(usbstr) is
- * 2 * len(str) + 2.
- * Returns the resulting length of the string in usbstr.
- * This function can accept overlapping usbstr and str as long as the overlap
- * does not cause data written to usbstr to overwrite data not yet read from
- * str.
- */
-static int make_usb_string(char *usbstr, size_t usblen, char *src,
-		size_t srclen)
-{
-	int len = 0;
-
-	if (usbstr && usblen >= 2 && src && *src && srclen) {
-		char *p;
-
-		if (usblen > 255)
-			usblen = 255;
-
-		p = usbstr + 1;
-		*p++ = 0x03;
-		len = 2;
-		while (srclen && len < usblen) {
-			*p++ = *src++;
-			*p++ = 0;
-			len += 2;
-			srclen--;
-		}
-		*usbstr = (char)len;
-	}
-	return len;
+	return cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR,
+			0x3700 | (cmd & 0xff), value, NULL, 0);
 }
 
 /*
@@ -361,8 +353,8 @@ static int make_usb_string(char *usbstr, size_t usblen, char *src,
 static int cp210x_setstr(struct usb_serial_port *port, int cmd, char *usbstr)
 {
 	unsigned len = usbstr[0];
-	int ret = cp210x_ctlmsg(port, 0xff, 0x40, 0x3700 | (cmd & 0xff), 0,
-			usbstr, len);
+	int ret = cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR,
+			0x3700 | (cmd & 0xff), 0, usbstr, len);
 	dbg("%s - cmd 0x%02x len %d ret %d", __FUNCTION__, cmd, len, ret);
 	return ret;
 }
@@ -372,8 +364,8 @@ static int cp210x_gpioset(struct usb_serial_port *port, u8 gpio)
 {
 	dbg("%s - port %d, gpio = 0x%.2x", __FUNCTION__, port->number, gpio);
 
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x37e1,
-			((uint16_t)gpio << 8) | GPIO_MASK, NULL, 0);
+	return cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR,
+			0x37e1, ((uint16_t)gpio << 8) | GPIO_MASK, NULL, 0);
 }
 
 /* Set select gpio bits */
@@ -401,8 +393,8 @@ static int cp210x_gpiosetb(struct usb_serial_port *port, u8 set, u8 clear)
 
 	dbg("%s - port %d, gpiob = 0x%.4x", __FUNCTION__, port->number, gpio);
 
-	/* FIXME: how about REQTYPE_HOST_TO_DEVICE instead of 0x40? */
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x37e1, gpio, NULL, 0);
+	return cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR,
+			0x37e1, gpio, NULL, 0);
 }
 
 static int cp210x_gpioget(struct usb_serial_port *port, u8 *gpio)
@@ -411,8 +403,8 @@ static int cp210x_gpioget(struct usb_serial_port *port, u8 *gpio)
 
 	dbg("%s - port %d", __FUNCTION__, port->number);
 
-	/* FIXME: how about REQTYPE_DEVICE_TO_HOST instead of 0xc0? */
-	ret = cp210x_ctlmsg(port, 0xff, 0xc0, 0x00c2, 0, gpio, 1);
+	ret = cp210x_ctlmsg(port, 0xff, USB_DIR_IN|USB_TYPE_VENDOR,
+			0x00c2, 0, gpio, 1);
 
 	dbg("%s - gpio = 0x%.2x (%d)", __FUNCTION__, *gpio, ret);
 
@@ -429,21 +421,17 @@ static int cp210x_portconfset(struct usb_serial_port *port,
 
 	memcpy(&lconfig, config, sizeof(lconfig));
 
-	/* Words from cp2103 are MSB */
+	/* Words from cp210x are MSB */
 	lconfig.reset.mode = cpu_to_be16(config->reset.mode);
 	lconfig.reset.latch = cpu_to_be16(config->reset.latch);
 	lconfig.suspend.mode = cpu_to_be16(config->suspend.mode);
 	lconfig.suspend.latch = cpu_to_be16(config->suspend.latch);
-#if 0 /* apparently not implemented by CP210X firmware */
-	lconfig.reset.lowPower = cpu_to_be16(config->reset.lowPower);
-	lconfig.suspend.lowPower = cpu_to_be16(config->suspend.lowPower);
-#else
+	/* apparently not implemented by CP210X firmware */
 	lconfig.suspend.lowPower = 0;
 	lconfig.reset.lowPower = 0;
-#endif
 
-	ret = cp210x_ctlmsg(port, 0xff, 0x40, 0x370c, 0, &lconfig,
-			sizeof(struct cp210x_port_config));
+	ret = cp210x_ctlmsg(port, 0xff, USB_TYPE_VENDOR, 0x370c,
+			0, &lconfig, sizeof(struct cp210x_port_config));
 	if (ret == sizeof(struct cp210x_port_config))
 		return 0;
 	else if (ret >= 0)
@@ -459,10 +447,10 @@ static int cp210x_portconfget(struct usb_serial_port *port,
 
 	dbg("%s", __FUNCTION__);
 
-	ret = cp210x_ctlmsg(port, 0xff, 0xc0, 0x370c, 0, config,
-			sizeof(struct cp210x_port_config));
+	ret = cp210x_ctlmsg(port, 0xff, USB_DIR_IN|USB_TYPE_VENDOR,
+			0x370c, 0, config, sizeof(struct cp210x_port_config));
 	if (ret == sizeof(struct cp210x_port_config)) {
-		/* Words from cp2103 are MSB */
+		/* Words from cp210x are MSB */
 		config->reset.mode = be16_to_cpu(config->reset.mode);
 		config->reset.lowPower = be16_to_cpu(config->reset.lowPower);
 		config->reset.latch = be16_to_cpu(config->reset.latch);
@@ -511,8 +499,9 @@ static int cp210x_get_config(struct usb_serial_port *port, u8 request,
 
 	/* Issue the request, attempting to read 'size' bytes */
 	result = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
-				request, REQTYPE_DEVICE_TO_HOST, 0x0000,
-				0, buf, size, 300);
+				request,
+				USB_DIR_IN|USB_TYPE_VENDOR|USB_RECIP_INTERFACE,
+				0x0000, 0, buf, size, 300);
 
 	/* Convert data into an array of integers */
 	for (i = 0; i < length; i++)
@@ -559,13 +548,13 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
 
 	if (size > 2) {
 		result = usb_control_msg(serial->dev,
-				usb_sndctrlpipe(serial->dev, 0),
-				request, REQTYPE_HOST_TO_DEVICE, 0x0000,
+				usb_sndctrlpipe(serial->dev, 0), request,
+				USB_TYPE_VENDOR|USB_RECIP_INTERFACE, 0x0000,
 				0, buf, size, 300);
 	} else {
 		result = usb_control_msg(serial->dev,
-				usb_sndctrlpipe(serial->dev, 0),
-				request, REQTYPE_HOST_TO_DEVICE, data[0],
+				usb_sndctrlpipe(serial->dev, 0), request,
+				USB_TYPE_VENDOR|USB_RECIP_INTERFACE, data[0],
 				0, NULL, 0, 300);
 	}
 
@@ -682,14 +671,14 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 			return -EFAULT;
 
 		/* this looks wrong: TIOCMSET isn't going to work right */
-		if (cp210x_tiocmset(port, file, cmd==TIOCMBIC ? 0 : val,
-					cmd==TIOCMBIC ? val : 0))
+		if (cp210x_tiocmset(port, file, (cmd == TIOCMBIC) ? 0 : val,
+					(cmd == TIOCMBIC) ? val : 0))
 			return -EFAULT;
 		return 0;
 	}
 	break;
 
-	case IOCTL_GPIOGET:
+	case CP210x_IOCTL_GPIOGET:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103) {
 		u8 gpio = 0;
 		if (!cp210x_gpioget(port, &gpio) && !copy_to_user(
@@ -699,27 +688,28 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	return -EFAULT;
 	break;
 
-	case IOCTL_GPIOSET:
+	case CP210x_IOCTL_GPIOSET:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103 &&
 			!cp210x_gpioset(port, arg))
 		return 0;
 	return -EFAULT;
 	break;
 
-	case IOCTL_GPIOBIC:
-	case IOCTL_GPIOBIS:
+	case CP210x_IOCTL_GPIOBIC:
+	case CP210x_IOCTL_GPIOBIS:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103 &&
-			!cp210x_gpiosetb(port, (cmd==IOCTL_GPIOBIC) ?  0 : arg,
-			(cmd==IOCTL_GPIOBIC) ? arg : 0))
+			!cp210x_gpiosetb(port,
+				(cmd == CP210x_IOCTL_GPIOBIC) ?  0 : arg,
+				(cmd == CP210x_IOCTL_GPIOBIC) ? arg : 0))
 		return 0;
 	return -EFAULT;
 	break;
 
-	case IOCTL_DEVICERESET:
+	case CP210x_IOCTL_DEVICERESET:
 	return cp210x_reset(port);
 	break;
 
-	case IOCTL_PORTCONFGET:
+	case CP210x_IOCTL_PORTCONFGET:
 	{
 		struct cp210x_port_config config;
 		if (!cp210x_portconfget(port, &config) && !copy_to_user(
@@ -730,7 +720,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	return -EFAULT;
 	break;
 
-	case IOCTL_PORTCONFSET:
+	case CP210x_IOCTL_PORTCONFSET:
 	{
 	struct cp210x_port_config config;
 	if (!copy_from_user(&config, (struct cp210x_port_config __user *)arg,
@@ -741,7 +731,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETVID:
+	case CP210x_IOCTL_SETVID:
 	{
 		unsigned int vid;
 		if (!copy_from_user(&vid, (unsigned int __user *)arg,
@@ -752,7 +742,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETPID:
+	case CP210x_IOCTL_SETPID:
 	{
 		unsigned int pid;
 		if (!copy_from_user(&pid, (unsigned int __user *)arg,
@@ -763,46 +753,31 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETMFG:
-	if (cp210x_has_setmfg()) {
-		char usbstr[CP210x_MAX_MFG_STRLEN * 2 + 2];
-		char *str = usbstr + sizeof(usbstr) - CP210x_MAX_MFG_STRLEN;
-		size_t len = cp210x_buf_from_user(str, arg,
-				CP210x_MAX_MFG_STRLEN);
-		len = make_usb_string(usbstr, sizeof(usbstr), str, len);
-		if (len && cp210x_setstr(port, 0x00, usbstr) == len)
-			return 0;
-	}
-	return -EFAULT;
-	break;
-
-	case IOCTL_SETPRODUCT:
+	case CP210x_IOCTL_SETPRODUCT:
 	{
-		char usbstr[CP210x_MAX_PRODUCT_STRLEN * 2 + 2];
-		char *str = usbstr + sizeof(usbstr) - CP210x_MAX_PRODUCT_STRLEN;
-		size_t len = cp210x_buf_from_user(str, arg,
-				CP210x_MAX_PRODUCT_STRLEN);
-		len = make_usb_string(usbstr, sizeof(usbstr), str, len);
+		char usbstr[USBSTRLEN(CP210x_MAX_PRODUCT_STRLEN)];
+		size_t len = cp210x_usbstr_from_user(usbstr,
+				(struct cp210x_buffer __user *)arg,
+				sizeof(usbstr));
 		if (len && cp210x_setstr(port, 0x03, usbstr) == len)
 			return 0;
 		return -EFAULT;
 	}
 	break;
 
-	case IOCTL_SETSERIAL:
+	case CP210x_IOCTL_SETSERIAL:
 	{
-		char usbstr[CP210x_MAX_SERIAL_STRLEN * 2 + 2];
-		char *str = usbstr + sizeof(usbstr) - CP210x_MAX_SERIAL_STRLEN;
-		size_t len = cp210x_buf_from_user(str, arg,
-				CP210x_MAX_SERIAL_STRLEN);
-		len = make_usb_string(usbstr, sizeof(usbstr), str, len);
+		char usbstr[USBSTRLEN(CP210x_MAX_SERIAL_STRLEN)];
+		size_t len = cp210x_usbstr_from_user(usbstr,
+				(struct cp210x_buffer __user *)arg,
+				sizeof(usbstr));
 		if (len && cp210x_setstr(port, 0x04, usbstr) == len)
 			return 0;
 		return -EFAULT;
 	}
 	break;
 
-	case IOCTL_SETDEVVER:
+	case CP210x_IOCTL_SETDEVVER:
 	{
 		unsigned int ver;
 		if (!copy_from_user(&ver, (unsigned int __user *)arg,