X-Git-Url: https://oss.titaniummirror.com/gitweb?a=blobdiff_plain;f=src%2Fcp210x.c.karmic;h=d418849fc02269bd5cc986715b81e3e8a4caad77;hb=185ac8c0b94807a01f510f17f45d402f47add83a;hp=707665782103b02ad8597c86c77c839a45b32e91;hpb=adcc360e576188af96b2dd22be2bed75e151d769;p=cp210x.git

diff --git a/src/cp210x.c.karmic b/src/cp210x.c.karmic
index 7076657..d418849 100644
--- a/src/cp210x.c.karmic
+++ b/src/cp210x.c.karmic
@@ -151,9 +151,13 @@ static struct usb_serial_driver cp210x_device = {
 	.disconnect		= cp210x_disconnect,
 };
 
+/* Control request types */
+#define REQTYPE_CTL_TO_DEVICE	USB_TYPE_VENDOR
+#define REQTYPE_CTL_TO_HOST	(USB_DIR_IN|REQTYPE_CTL_TO_DEVICE)
+
 /* Config request types */
-#define REQTYPE_HOST_TO_DEVICE	0x41
-#define REQTYPE_DEVICE_TO_HOST	0xc1
+#define REQTYPE_HOST_TO_DEVICE	(USB_TYPE_VENDOR|USB_RECIP_INTERFACE)
+#define REQTYPE_DEVICE_TO_HOST	(USB_DIR_IN|REQTYPE_HOST_TO_DEVICE)
 
 /* Config request codes */
 #define CP210X_IFC_ENABLE	0x00
@@ -269,10 +273,11 @@ static int make_usb_string(char *usbstr, size_t usblen, char *src,
  * is the size of the buffer at kbuf.
  * Returns the number of bytes used in kbuf.
  */
-static size_t cp210x_usbstr_from_user(char *kbuf, unsigned long ubuf, size_t klen)
+static size_t cp210x_usbstr_from_user(char *kbuf, unsigned long ubuf,
+		size_t klen)
 {
 	struct cp210x_buffer t;
-	char* str;
+	char *str;
 	size_t slen;
 
 	if (!kbuf || !ubuf || !klen)
@@ -314,9 +319,10 @@ static int cp210x_ctlmsg(struct usb_serial_port *port, u8 request,
 	u8 *tbuf;
 	int ret;
 
-	if (!(tbuf = kmalloc(size, GFP_KERNEL)))
+	tbuf = kmalloc(size, GFP_KERNEL);
+	if (!tbuf)
 		return -ENOMEM;
-	if (requestype & 0x80) {
+	if (requestype & USB_DIR_IN) {
 		ret = usb_control_msg(dev, usb_rcvctrlpipe(dev, 0), request,
 				requestype, value, index, tbuf, size, 300);
 		if (ret > 0 && size)
@@ -329,8 +335,9 @@ static int cp210x_ctlmsg(struct usb_serial_port *port, u8 request,
 	}
 	kfree(tbuf);
 	if (ret < 0 && ret != -EPIPE) {
-		dev_printk(KERN_DEBUG, &dev->dev, "cp210x: control failed cmd rqt %u "
-				"rq %u len %u ret %d\n", requestype, request, size, ret);
+		dev_printk(KERN_DEBUG, &dev->dev,
+			"cp210x: ctl failed cmd rqt %u rq %u len %u ret %d\n",
+			requestype, request, size, ret);
 	}
 	return ret;
 }
@@ -339,16 +346,11 @@ static int cp210x_reset(struct usb_serial_port *port)
 {
 	dbg("%s", __func__);
 
-#if 1
-	/* Is this better than usb_device_reset?  It may be.  Once a client issues
-	 * the reset ioctl, it must disconnect and reconnect, since the USB
-	 * connections are torn down.  We also ignore the error return, since
-	 * the part resets and doesn't send one...
+	/* Instructing the CP210X to reset seems to work more reliably than
+	 * calling usb_reset_device().
 	 */
-	cp210x_ctlmsg(port, 0xff, 0x40, 0x0008, 0x00, NULL, 0);
-#else
-	usb_reset_device(port->serial->dev);
-#endif
+	cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE,
+			0x0008, 0x00, NULL, 0);
 	return 0;
 }
 
@@ -365,8 +367,8 @@ static int cp210x_get_partnum(struct usb_serial_port *port)
 			_partnum = CP210x_PART_CP2101;
 		else if (addr == 0x01) {
 			/* Must query part to determine part number */
-			if (cp210x_ctlmsg(port, 0xff, 0xc0, 0x370b, 0x00,
-					&_partnum, 1) != 1)
+			if (cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_HOST,
+					0x370b, 0x00, &_partnum, 1) != 1)
 				_partnum = CP210x_PART_UNKNOWN;
 		}
 	}
@@ -377,8 +379,8 @@ static int cp210x_get_partnum(struct usb_serial_port *port)
 static inline int cp210x_setu16(struct usb_serial_port *port, int cmd,
 		unsigned int value)
 {
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x3700 | (cmd & 0xff),
-			value, NULL, 0);
+	return cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE,
+			0x3700 | (cmd & 0xff), value, NULL, 0);
 }
 
 /*
@@ -390,8 +392,8 @@ static inline int cp210x_setu16(struct usb_serial_port *port, int cmd,
 static int cp210x_setstr(struct usb_serial_port *port, int cmd, char *usbstr)
 {
 	unsigned len = usbstr[0];
-	int ret = cp210x_ctlmsg(port, 0xff, 0x40, 0x3700 | (cmd & 0xff), 0,
-			usbstr, len);
+	int ret = cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE,
+			0x3700 | (cmd & 0xff), 0, usbstr, len);
 	dbg("%s - cmd 0x%02x len %d ret %d", __func__, cmd, len, ret);
 	return ret;
 }
@@ -401,8 +403,8 @@ static int cp210x_gpioset(struct usb_serial_port *port, u8 gpio)
 {
 	dbg("%s - port %d, gpio = 0x%.2x", __func__, port->number, gpio);
 
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x37e1,
-			((uint16_t)gpio << 8) | GPIO_MASK, NULL, 0);
+	return cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE,
+			0x37e1, ((uint16_t)gpio << 8) | GPIO_MASK, NULL, 0);
 }
 
 /* Set select gpio bits */
@@ -430,8 +432,8 @@ static int cp210x_gpiosetb(struct usb_serial_port *port, u8 set, u8 clear)
 
 	dbg("%s - port %d, gpiob = 0x%.4x", __func__, port->number, gpio);
 
-	/* FIXME: how about REQTYPE_HOST_TO_DEVICE instead of 0x40? */
-	return cp210x_ctlmsg(port, 0xff, 0x40, 0x37e1, gpio, NULL, 0);
+	return cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE,
+			0x37e1, gpio, NULL, 0);
 }
 
 static int cp210x_gpioget(struct usb_serial_port *port, u8 *gpio)
@@ -440,8 +442,8 @@ static int cp210x_gpioget(struct usb_serial_port *port, u8 *gpio)
 
 	dbg("%s - port %d", __func__, port->number);
 
-	/* FIXME: how about REQTYPE_DEVICE_TO_HOST instead of 0xc0? */
-	ret = cp210x_ctlmsg(port, 0xff, 0xc0, 0x00c2, 0, gpio, 1);
+	ret = cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_HOST,
+			0x00c2, 0, gpio, 1);
 
 	dbg("%s - gpio = 0x%.2x (%d)", __func__, *gpio, ret);
 
@@ -458,21 +460,17 @@ static int cp210x_portconfset(struct usb_serial_port *port,
 
 	memcpy(&lconfig, config, sizeof(lconfig));
 
-	/* Words from cp2103 are MSB */
+	/* Words from cp210x are MSB */
 	lconfig.reset.mode = cpu_to_be16(config->reset.mode);
 	lconfig.reset.latch = cpu_to_be16(config->reset.latch);
 	lconfig.suspend.mode = cpu_to_be16(config->suspend.mode);
 	lconfig.suspend.latch = cpu_to_be16(config->suspend.latch);
-#if 0 /* apparently not implemented by CP210X firmware */
-	lconfig.reset.lowPower = cpu_to_be16(config->reset.lowPower);
-	lconfig.suspend.lowPower = cpu_to_be16(config->suspend.lowPower);
-#else
+	/* apparently not implemented by CP210X firmware */
 	lconfig.suspend.lowPower = 0;
 	lconfig.reset.lowPower = 0;
-#endif
 
-	ret = cp210x_ctlmsg(port, 0xff, 0x40, 0x370c, 0, &lconfig,
-			sizeof(struct cp210x_port_config));
+	ret = cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_DEVICE, 0x370c,
+			0, &lconfig, sizeof(struct cp210x_port_config));
 	if (ret == sizeof(struct cp210x_port_config))
 		return 0;
 	else if (ret >= 0)
@@ -488,10 +486,10 @@ static int cp210x_portconfget(struct usb_serial_port *port,
 
 	dbg("%s", __func__);
 
-	ret = cp210x_ctlmsg(port, 0xff, 0xc0, 0x370c, 0, config,
-			sizeof(struct cp210x_port_config));
+	ret = cp210x_ctlmsg(port, 0xff, REQTYPE_CTL_TO_HOST,
+			0x370c, 0, config, sizeof(struct cp210x_port_config));
 	if (ret == sizeof(struct cp210x_port_config)) {
-		/* Words from cp2103 are MSB */
+		/* Words from cp210x are MSB */
 		config->reset.mode = be16_to_cpu(config->reset.mode);
 		config->reset.lowPower = be16_to_cpu(config->reset.lowPower);
 		config->reset.latch = be16_to_cpu(config->reset.latch);
@@ -757,8 +755,8 @@ static int cp210x_ioctl(struct tty_struct *tty, struct file *file,
 			return -EFAULT;
 
 		/* this looks wrong: TIOCMSET isn't going to work right */
-		if (cp210x_tiocmset(tty, file, cmd==TIOCMBIC ? 0 : val,
-					cmd==TIOCMBIC ? val : 0))
+		if (cp210x_tiocmset(tty, file, (cmd == TIOCMBIC) ? 0 : val,
+					(cmd == TIOCMBIC) ? val : 0))
 			return -EFAULT;
 		return 0;
 	}
@@ -785,8 +783,8 @@ static int cp210x_ioctl(struct tty_struct *tty, struct file *file,
 	case CP210x_IOCTL_GPIOBIS:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103 &&
 			!cp210x_gpiosetb(port,
-				(cmd==CP210x_IOCTL_GPIOBIC) ?  0 : arg,
-				(cmd==CP210x_IOCTL_GPIOBIC) ? arg : 0))
+				(cmd == CP210x_IOCTL_GPIOBIC) ?  0 : arg,
+				(cmd == CP210x_IOCTL_GPIOBIC) ? arg : 0))
 		return 0;
 	return -EFAULT;
 	break;