X-Git-Url: https://oss.titaniummirror.com/gitweb?p=cp210x.git;a=blobdiff_plain;f=src%2Fcp210x.c;h=1ec4b8eaa403d9c581e0474dde5d695933744e62;hp=b7de40f900f28a2c21e8cd526b7de2d1f805eae3;hb=adcc360e576188af96b2dd22be2bed75e151d769;hpb=e491c3e2ddc2dd42120f2c981d3c1985118a0f6b

diff --git a/src/cp210x.c b/src/cp210x.c
index b7de40f..1ec4b8e 100644
--- a/src/cp210x.c
+++ b/src/cp210x.c
@@ -252,19 +252,21 @@ static size_t cp210x_usbstr_from_user(char *kbuf, unsigned long ubuf, size_t kle
 {
 	struct cp210x_buffer t;
 	char* str;
+	size_t slen;
 
 	if (!kbuf || !ubuf || !klen)
 		return 0;
 	if (copy_from_user(&t, (struct cp210x_buffer __user *)ubuf, sizeof(t)))
 		return 0;
-	if (!t.buf || !t.len)
+	if (!t.buf || !t.len || USBSTRLEN(t.len) > klen)
 		return 0;
-	if (t.len < klen)
-		klen = t.len;
-	str = kbuf + klen - t.len;
-	if (copy_from_user(kbuf + klen - t.len, (u8 __user *)t.buf, klen))
+	slen = (klen - 2) / 2;
+	if (t.len < slen)
+		slen = t.len;
+	str = kbuf + klen - slen;
+	if (copy_from_user(str, (u8 __user *)t.buf, slen))
 		return 0;
-	return make_usb_string(kbuf, klen, str, t.len);
+	return make_usb_string(kbuf, klen, str, slen);
 }
 
 /* cp210x_has_setmfg
@@ -695,7 +697,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_GPIOGET:
+	case CP210x_IOCTL_GPIOGET:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103) {
 		u8 gpio = 0;
 		if (!cp210x_gpioget(port, &gpio) && !copy_to_user(
@@ -705,27 +707,28 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	return -EFAULT;
 	break;
 
-	case IOCTL_GPIOSET:
+	case CP210x_IOCTL_GPIOSET:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103 &&
 			!cp210x_gpioset(port, arg))
 		return 0;
 	return -EFAULT;
 	break;
 
-	case IOCTL_GPIOBIC:
-	case IOCTL_GPIOBIS:
+	case CP210x_IOCTL_GPIOBIC:
+	case CP210x_IOCTL_GPIOBIS:
 	if (cp210x_get_partnum(port) == CP210x_PART_CP2103 &&
-			!cp210x_gpiosetb(port, (cmd==IOCTL_GPIOBIC) ?  0 : arg,
-			(cmd==IOCTL_GPIOBIC) ? arg : 0))
+			!cp210x_gpiosetb(port,
+				(cmd==CP210x_IOCTL_GPIOBIC) ?  0 : arg,
+				(cmd==CP210x_IOCTL_GPIOBIC) ? arg : 0))
 		return 0;
 	return -EFAULT;
 	break;
 
-	case IOCTL_DEVICERESET:
+	case CP210x_IOCTL_DEVICERESET:
 	return cp210x_reset(port);
 	break;
 
-	case IOCTL_PORTCONFGET:
+	case CP210x_IOCTL_PORTCONFGET:
 	{
 		struct cp210x_port_config config;
 		if (!cp210x_portconfget(port, &config) && !copy_to_user(
@@ -736,7 +739,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	return -EFAULT;
 	break;
 
-	case IOCTL_PORTCONFSET:
+	case CP210x_IOCTL_PORTCONFSET:
 	{
 	struct cp210x_port_config config;
 	if (!copy_from_user(&config, (struct cp210x_port_config __user *)arg,
@@ -747,7 +750,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETVID:
+	case CP210x_IOCTL_SETVID:
 	{
 		unsigned int vid;
 		if (!copy_from_user(&vid, (unsigned int __user *)arg,
@@ -758,7 +761,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETPID:
+	case CP210x_IOCTL_SETPID:
 	{
 		unsigned int pid;
 		if (!copy_from_user(&pid, (unsigned int __user *)arg,
@@ -769,7 +772,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETMFG:
+	case CP210x_IOCTL_SETMFG:
 	if (cp210x_has_setmfg()) {
 		char usbstr[USBSTRLEN(CP210x_MAX_MFG_STRLEN)];
 		size_t len = cp210x_usbstr_from_user(usbstr, arg,
@@ -780,7 +783,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	return -EFAULT;
 	break;
 
-	case IOCTL_SETPRODUCT:
+	case CP210x_IOCTL_SETPRODUCT:
 	{
 		char usbstr[USBSTRLEN(CP210x_MAX_PRODUCT_STRLEN)];
 		size_t len = cp210x_usbstr_from_user(usbstr, arg,
@@ -791,7 +794,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETSERIAL:
+	case CP210x_IOCTL_SETSERIAL:
 	{
 		char usbstr[USBSTRLEN(CP210x_MAX_SERIAL_STRLEN)];
 		size_t len = cp210x_usbstr_from_user(usbstr, arg,
@@ -802,7 +805,7 @@ static int cp210x_ioctl(struct usb_serial_port *port, struct file *file,
 	}
 	break;
 
-	case IOCTL_SETDEVVER:
+	case CP210x_IOCTL_SETDEVVER:
 	{
 		unsigned int ver;
 		if (!copy_from_user(&ver, (unsigned int __user *)arg,