Fix off by one error

[tinyos-2.x.git] / tos / lib / tossim / sim_gain.c

diff --git a/tos/lib/tossim/sim_gain.c b/tos/lib/tossim/sim_gain.c
index 641f9fe68f587c1bdb63d8fbea1761664021afc8..1d3ad795e4249bc6c5389759903edad0e6282a3c 100644 (file)
--- a/tos/lib/tossim/sim_gain.c
+++ b/tos/lib/tossim/sim_gain.c
@@ -7,11 +7,11 @@ typedef struct sim_gain_noise {
 
 
 gain_entry_t* connectivity[TOSSIM_MAX_NODES + 1];
-sim_gain_noise_t noise[TOSSIM_MAX_NODES + 1];
+sim_gain_noise_t localNoise[TOSSIM_MAX_NODES + 1];
 double sensitivity = 4.0;
 
 gain_entry_t* sim_gain_allocate_link(int mote);
-void sim_gain_deallocate_link(gain_entry_t* link);
+void sim_gain_deallocate_link(gain_entry_t* linkToDelete);
 
 gain_entry_t* sim_gain_first(int src) __attribute__ ((C, spontaneous)) {
   if (src > TOSSIM_MAX_NODES) {
@@ -20,8 +20,8 @@ gain_entry_t* sim_gain_first(int src) __attribute__ ((C, spontaneous)) {
   return connectivity[src];
 }
 
-gain_entry_t* sim_gain_next(gain_entry_t* link) __attribute__ ((C, spontaneous)) {
-  return link->next;
+gain_entry_t* sim_gain_next(gain_entry_t* currentLink) __attribute__ ((C, spontaneous)) {
+  return currentLink->next;
 }
 
 void sim_gain_add(int src, int dest, double gain) __attribute__ ((C, spontaneous))  {
@@ -60,11 +60,13 @@ double sim_gain_value(int src, int dest) __attribute__ ((C, spontaneous))  {
   while (current != NULL) {
     if (current->mote == dest) {
       sim_set_node(temp);
+      dbg("Gain", "Getting link from %i to %i with gain %f\n", src, dest, current->gain);
       return current->gain;
     }
     current = current->next;
   }
   sim_set_node(temp);
+  dbg("Gain", "Getting default link from %i to %i with gain %f\n", src, dest, 1.0);
   return 1.0;
 }
 
@@ -99,6 +101,7 @@ void sim_gain_remove(int src, int dest) __attribute__ ((C, spontaneous))  {
   prevLink = NULL;
     
   while (current != NULL) {
+    gain_entry_t* tmp;
     if (current->mote == dest) {
       if (prevLink == NULL) {
        connectivity[src] = current->next;
@@ -106,8 +109,9 @@ void sim_gain_remove(int src, int dest) __attribute__ ((C, spontaneous))  {
       else {
        prevLink->next = current->next;
       }
+      tmp = current->next;
       sim_gain_deallocate_link(current);
-      current = prevLink->next;
+      current = tmp;
     }
     else {
       prevLink = current;
@@ -121,22 +125,22 @@ void sim_gain_set_noise_floor(int node, double mean, double range) __attribute__
   if (node > TOSSIM_MAX_NODES) {
     node = TOSSIM_MAX_NODES;
   }
-  noise[node].mean = mean;
-  noise[node].range = range;
+  localNoise[node].mean = mean;
+  localNoise[node].range = range;
 }
 
 double sim_gain_noise_mean(int node) {
   if (node > TOSSIM_MAX_NODES) {
     node = TOSSIM_MAX_NODES;
   }
-  return noise[node].mean;
+  return localNoise[node].mean;
 }
 
 double sim_gain_noise_range(int node) {
   if (node > TOSSIM_MAX_NODES) {
     node = TOSSIM_MAX_NODES;
   }
-  return noise[node].range;
+  return localNoise[node].range;
 }
 
 // Pick a number a number from the uniform distribution of
@@ -146,24 +150,24 @@ double sim_gain_sample_noise(int node)  __attribute__ ((C, spontaneous)) {
   if (node > TOSSIM_MAX_NODES) {
     node = TOSSIM_MAX_NODES;
   } 
-  val = noise[node].mean;
+  val = localNoise[node].mean;
   adjust = (sim_random() % 2000000);
   adjust /= 1000000.0;
   adjust -= 1.0;
-  adjust *= noise[node].range;
+  adjust *= localNoise[node].range;
   return val + adjust;
 }
 
 gain_entry_t* sim_gain_allocate_link(int mote) {
-  gain_entry_t* link = (gain_entry_t*)malloc(sizeof(gain_entry_t));
-  link->next = NULL;
-  link->mote = mote;
-  link->gain = -10000000.0;
-  return link;
+  gain_entry_t* newLink = (gain_entry_t*)malloc(sizeof(gain_entry_t));
+  newLink->next = NULL;
+  newLink->mote = mote;
+  newLink->gain = -10000000.0;
+  return newLink;
 }
 
-void sim_gain_deallocate_link(gain_entry_t* link) __attribute__ ((C, spontaneous)) {
-  free(link);
+void sim_gain_deallocate_link(gain_entry_t* linkToDelete) __attribute__ ((C, spontaneous)) {
+  free(linkToDelete);
 }
 
 void sim_gain_set_sensitivity(double s) __attribute__ ((C, spontaneous)) {