Properly handle wrong arg count when -t

diff --git a/repo_shell.c b/repo_shell.c
index 4d9f79b8325fa0626efbaccafe0214fdb9379ff0..dc9b8d611e6aa808c7a369671fa3b2784f15295e 100644 (file)
--- a/repo_shell.c
+++ b/repo_shell.c
@@ -203,9 +203,12 @@ int main(int argc, char **argv)
   if (ini_parse(CFG_FILE, ini_handler, &cfg) < 0)
     die("cannot read config file %s", CFG_FILE);
 
-  if (argc == 4 && (!strcmp(argv[1], "-t") ||
-      !strcmp(argv[1], "--test"))) {
-    perms_t p = git_acl(argv[2], argv[3], cfg.git_acl_file);
+  if ((!strcmp(argv[1], "-t") || !strcmp(argv[1], "--test"))) {
+    perms_t p;
+
+    if (argc !=4)
+      die("usage: %s -t <user> <repo>", argv[0]);
+    p = git_acl(argv[2], argv[3], cfg.git_acl_file);
     fprintf(stderr,
         "user '%s' repo '%s' perms '%s'\n  via userid '%s' repoid '%s'\n",
         argv[2], argv[3], git_acl_perms_as_str(p), git_acl_last_userid(),